Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Transformer iterator to apply a limiter to jittering #6331

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

buggmagnet
Copy link
Contributor

@buggmagnet buggmagnet commented Jun 7, 2024

While trying to use a RetryStrategy, I found out that it ignored the maxDelay imposed by the exponentialBackoff RetryDelay.

This PR fixes that.


This change is Reviewable

@buggmagnet buggmagnet added the iOS Issues related to iOS label Jun 7, 2024
@buggmagnet buggmagnet requested review from rablador and mojganii June 7, 2024 13:53
@buggmagnet buggmagnet self-assigned this Jun 7, 2024
Copy link

linear bot commented Jun 7, 2024

@buggmagnet buggmagnet force-pushed the jitter-strategy-breaks-exponential-backoff-ios-726 branch from 9cbc639 to b9868b7 Compare June 7, 2024 14:01
@buggmagnet buggmagnet requested a review from pinkisemils June 10, 2024 11:15
Copy link
Collaborator

@mojganii mojganii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 6 files reviewed, all discussions resolved

@buggmagnet buggmagnet force-pushed the jitter-strategy-breaks-exponential-backoff-ios-726 branch from b9868b7 to ab69f76 Compare June 10, 2024 14:04
@buggmagnet buggmagnet merged commit 379cee2 into main Jun 10, 2024
6 of 7 checks passed
@buggmagnet buggmagnet deleted the jitter-strategy-breaks-exponential-backoff-ios-726 branch June 10, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants